Diagnose CI build failures #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjbenfold
force-pushed
the
wjbenfold-fix-build
branch
from
c553f40 to
ac6ca6e
Compare
wjbenfold
changed the title
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 6 6
Lines 816 816
Branches 103 121 +18
=======================================
Hits 743 743
Misses 61 61
Partials 12 12 Continue to review full report at Codecov.
|
|
I think that I've fixed the issue blocking #205 however I think it's important to be aware when reviewing that I don't fully understand the code I've changed. The tests pass now though? |
|
I can't assign reviewers in this repo, so paging @bjlittle and @trexfeathers? |
trexfeathers
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Testing the CI test failures against hypotheses of what might be wrong